mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Resource Monitoring 2: Adding global statistics.
Date Wed, 30 Jan 2013 01:19:00 GMT


> On Jan. 28, 2013, 7:54 p.m., Vinod Kone wrote:
> > third_party/libprocess/src/process.cpp, line 1415
> > <https://reviews.apache.org/r/9090/diff/1/?file=251527#file251527line1415>
> >
> >     We don't want libraries to automatically spit log messages.
> >     
> >     In other words, we prefer VLOG so that users can specifically request them (by
setting GLOG_v) if they are so interested.
> 
> Ben Mahler wrote:
>     Gotcha, I see now that there's only VLOG in process.cpp. It's too bad that it will
require the user to re-run with GLOG_v if we need information from libprocess logging.

well, there is an endpoint (/logging?) to toggle logging at run time.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9090/#review15761
-----------------------------------------------------------


On Jan. 28, 2013, 10:49 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9090/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2013, 10:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This adds a global Statistics object for libprocess, which enables centralized stats
across Processes.
> 
> I'd love to eventually plumb stats into libprocess and export to the webui! (MESOS-320)
> 
> 
> This addresses bug MESOS-324.
>     https://issues.apache.org/jira/browse/MESOS-324
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/include/process/statistics.hpp 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9

>   third_party/libprocess/src/process.cpp 72e437862ee0b35126c16d32bec79ef76a4e2b23 
>   third_party/libprocess/src/statistics.cpp 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f

> 
> Diff: https://reviews.apache.org/r/9090/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message