mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Slave Restart (Part Tres): StatusUpdatesManager integration into the slave
Date Wed, 16 Jan 2013 23:11:30 GMT


> On Jan. 16, 2013, 7:33 p.m., Ben Mahler wrote:
> > src/slave/slave.cpp, line 801
> > <https://reviews.apache.org/r/7655/diff/8/?file=238494#file238494line801>
> >
> >     Any reason not to use the: "Failed to checkpoint..." log format?
> 
> Vinod Kone wrote:
>     I want to make sure it says that the failure is in the status update manager.
>     
>     Saying, Failed to checkpoint.....blah..by status update manager doesn't read nice.
>     
>     We might have to say.. "Status update manager failed to..".
>     
>     Also, I don't like "Failed to" for warnings. Sounds more ominous than intended.

Ok please use "could not" in that case.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7655/#review15397
-----------------------------------------------------------


On Jan. 16, 2013, 11:10 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7655/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 11:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> Integrated SUM into slave.
> 
> 
> This addresses bug MESOS-110.
>     https://issues.apache.org/jira/browse/MESOS-110
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 38235157d45bdccb676e5c3241c21b585a6f8801 
>   src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66 
>   src/slave/gc.cpp fe22f9b557215514e3d432d36af9dc0c377c437b 
>   src/slave/paths.hpp fbf3fd84fb8f2590311b18d2afec2d2e0d30ef0a 
>   src/slave/slave.hpp e9f7b659ca2860501840b3d01e69915ebd162039 
>   src/slave/slave.cpp 9755b46f97173d6fcc9ab1fd63e0e4814b3bc018 
>   src/slave/status_update_manager.hpp PRE-CREATION 
>   src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 
>   src/tests/status_update_manager_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/7655/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message