mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Add tests for http encoding.
Date Thu, 03 Jan 2013 19:46:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8799/#review15048
-----------------------------------------------------------

Ship it!



third_party/libprocess/src/tests/encoder_tests.cpp
<https://reviews.apache.org/r/8799/#comment32603>

    s/= ResponseDecoder()// ?



third_party/libprocess/src/tests/encoder_tests.cpp
<https://reviews.apache.org/r/8799/#comment32604>

    A comment here that these are un-acceptable requests (as you did below in line 66) would
be great.


- Vinod Kone


On Jan. 2, 2013, 2:54 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8799/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2013, 2:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> See above.
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099 
>   third_party/libprocess/src/tests/encoder_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8799/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message