mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Fixed regression in make clean for hadoop.
Date Wed, 19 Dec 2012 18:59:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8686/#review14729
-----------------------------------------------------------

Ship it!


can you change all  '-rm' to 'rm' elsewhere in the makefile to make it consistent.

- Vinod Kone


On Dec. 19, 2012, 6:27 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8686/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2012, 6:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> I broke the make clean target for hadoop when attempting to fix the makefile.
> 
> Reading the 'Makefile execution' section in the link below was insightful to me:
> http://pubs.opengroup.org/onlinepubs/009695399/utilities/make.html
> 
> Since it's rm -f, the lack of presence is not considered an error anyway.
> 
> 
> This addresses bug MESOS-325.
>     https://issues.apache.org/jira/browse/MESOS-325
> 
> 
> Diffs
> -----
> 
>   hadoop/Makefile.am 46d16f7c03cda217d1851d78515cad96f60cba2b 
> 
> Diff: https://reviews.apache.org/r/8686/diff/
> 
> 
> Testing
> -------
> 
> bootstrap, configure, make clean
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message