mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Slave Restart (Part Five): Implemented non-child process monitoring in reaper
Date Mon, 17 Dec 2012 22:22:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8570/#review14619
-----------------------------------------------------------



src/linux/proc.cpp
<https://reviews.apache.org/r/8570/#comment31033>

    Yes, this way we can do testing on OS X.



src/slave/reaper.cpp
<https://reviews.apache.org/r/8570/#comment31035>

    No need to have status declared above, just declare it in this block and also declare
it below (down by the other waitpid call). That way you don't need to "reset" the status.



src/slave/reaper.cpp
<https://reviews.apache.org/r/8570/#comment31036>

    Ahh, why aren't we checking for an error?



src/slave/reaper.cpp
<https://reviews.apache.org/r/8570/#comment31037>

    Won't this always send a notify even if the pid doesn't exist?



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/8570/#comment31034>

    You should be able to do 'listener.self()' rather than save the 'mpl' variable.


- Benjamin Hindman


On Dec. 13, 2012, 10:18 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8570/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2012, 10:18 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> Needed this to properly monitor the exit status of re-connected executors, as they will
be parented by INIT. 
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66 
>   src/linux/proc.hpp 6c84a73ab1c4d6893390f96eae15422c21001328 
>   src/linux/proc.cpp 99df77447ddfb07a5febec9ebfed396778665041 
>   src/slave/reaper.hpp b9aa62daa42bdaa736ade43884982529ba3d4bb1 
>   src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 
>   src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 
>   src/tests/slave_recovery_tests.cpp PRE-CREATION 
>   src/tests/utils.hpp be457117515ee727af101370b26bf9188afb8f45 
> 
> Diff: https://reviews.apache.org/r/8570/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message