mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Review Request: Added profiler endpoints in libprocess.
Date Tue, 11 Dec 2012 00:53:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8453/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Description
-------

This adds the following endpoints to libprocess:

'/profiler/start': Starts the profiler via ProfilerStart()
'/profiler/stop': Stops the profiler via ProfilerStop(), also returns the output file.

This allows profiling libprocess on the fly.
Note that it's not considered stable on 64 bit systems, due to issues with libunwind and glibc.


Diffs
-----

  third_party/libprocess/Makefile.am 6b68c69b07b831255d34a68d7b9b4b37eee55167 
  third_party/libprocess/include/process/profiler.hpp PRE-CREATION 
  third_party/libprocess/src/process.cpp e408ca9274f1253e3e67c656561a9366dd2bce33 

Diff: https://reviews.apache.org/r/8453/diff/


Testing
-------

Profiled using mesos-local and examined output.

FWIW I didn't observe any crashes, but I've only profiled with mesos-local and for O(minutes).


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message