mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Mahler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-285) configure.macosx checks for version "10.7" but should check for 10.7 or greater
Date Tue, 13 Nov 2012 00:21:12 GMT

    [ https://issues.apache.org/jira/browse/MESOS-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495779#comment-13495779
] 

Benjamin Mahler commented on MESOS-285:
---------------------------------------

I've bundled a fix for this in a review I just sent out: https://reviews.apache.org/r/8026/
                
> configure.macosx checks for version "10.7" but should check for 10.7 or greater
> -------------------------------------------------------------------------------
>
>                 Key: MESOS-285
>                 URL: https://issues.apache.org/jira/browse/MESOS-285
>             Project: Mesos
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.9.0
>         Environment: Mac OS X Mountain Lion
>            Reporter: Andy Konwinski
>
> Starting in OS X 10.7 (Lion) the location of jni.h is different. The configure.macosx
addresses this by checking for version 10.7 and adding the new location to JAVA_CPPFLAGS.
However, the check currently only tests for version 10.7 when it should check for 10.7 or
greater. See the exact line I'm talking about in the current head of trunk at https://github.com/apache/mesos/blob/fcc113f93113a32b26e668b7d27b1110e72a7dac/configure.macosx#L6
> if test ! -z `sw_vers -productVersion | grep 10.7`; then
> I believe a fix would be to have this line instead use Bash's extended test command (as
suggested in the comment by user "Steev" on this blog post http://bkhome.org/blog/?viewDetailed=02199)
which can compare dotted version numbers:
> osx_version=`sw_vers -productVersion`
> if [[ "$osx_version" == "10.7" || "$osx_version" > "10.7" ]]; then
> At least, this seems to work for me on 10.8.1 (Mountain Lion).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message