mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Encoding JSON strings as ASCII (fix for binary data in JSON strings).
Date Thu, 15 Nov 2012 21:58:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8056/#review13488
-----------------------------------------------------------

Ship it!



third_party/libprocess/include/stout/json.hpp
<https://reviews.apache.org/r/8056/#comment28925>

    s/are also escaping/also escape/
    
    s/we're not encode/ we don't escape/


- Vinod Kone


On Nov. 14, 2012, 10:16 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8056/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2012, 10:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> At twitter, we had an executor using binary data in the TaskInfo.data field. Since we
can't encode unicode / binary data, this breaks the JSON endpoint and the webui.
> 
> This fixes the break, as well as allows browsing binary files in the webui (however,
encoded as ASCII).
> 
> 
> Diffs
> -----
> 
>   src/tests/stout_tests.cpp efdb47f1d2401f9175a05fc65922d9ab7e383666 
>   third_party/libprocess/include/process/http.hpp f8d0a5886c77eaf885732346b89be326e89afad6

>   third_party/libprocess/include/stout/json.hpp 1c66dfd324619222f4ed168b7cf18e8f5e558b23

> 
> Diff: https://reviews.apache.org/r/8056/diff/
> 
> 
> Testing
> -------
> 
> make check + added json test
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message