mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Fixed log levels
Date Tue, 13 Nov 2012 06:04:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8024/#review13383
-----------------------------------------------------------

Ship it!


Perhaps a more descriptive summary? "Changed log granularities to reduce noise."


src/slave/slave.cpp
<https://reviews.apache.org/r/8024/#comment28685>

    This one seems like it would be noisy given that once we get the usage we print it out.
    
    Let's kill this one altogether?


- Ben Mahler


On Nov. 12, 2012, 11:53 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8024/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2012, 11:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/exec/exec.cpp 11cb64dd3f6d3992072582f2b6d6e6d9220eb48d 
>   src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab

>   src/master/master.hpp 9920decdbc9ae0aa597ce40039ddb029308e1cc6 
>   src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 
>   src/sched/sched.cpp a1247f90836a7f7ca333d92544a065cde91ace17 
>   src/slave/gc.cpp 679504e51922c5ea54a476d061262e8e8f2aa4b6 
>   src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f 
> 
> Diff: https://reviews.apache.org/r/8024/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message