mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Added an EXIT function to stout.
Date Tue, 06 Nov 2012 07:24:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7781/#review13128
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Nov. 6, 2012, 4:09 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7781/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 4:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This adds a consistent way for us to exit without alarming the user with a stack trace.
E.g.
> EXIT(1) << "Cgroups cannot be enabled because you run an old kernel";
> 
> Part 2, will refactor usage of:
>     std::cerr << "Cgroups can't be enabled." << std::endl;
>     abort();
> to become:
>     EXIT(1) << "Cgroups can't be enabled.";
> 
> Part 3, will kill the old files (if all the usages can be switched):
>     stout/fatal.hpp
>     libprocess/src/fatal.hpp
>     libprocess/src/fatal.cpp
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/Makefile.am f32c184ca8cc8852b6c90f3c85a8f99e10ed781b 
>   third_party/libprocess/include/stout/exit.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/7781/diff/
> 
> 
> Testing
> -------
> 
> CentOS: make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message