mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Remove copy constructors from master / slave structs. Zero-copy manipulation of completed tasks / frameworks / executors.
Date Fri, 02 Nov 2012 23:47:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7845/
-----------------------------------------------------------

(Updated Nov. 2, 2012, 11:47 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Description (updated)
-------

We were allowing default constructors in the master / slave data structs, which led to MESOS-303
when I added code that triggered copies.

So this change does the following to the structs:
  -Explicitly disallow copying / assignment.
  -Use circular_buffers of shared_ptrs to hold completed data.
  -This allows us to remove the explicit deletes of the structs, and transition the pointer
ownership into the completed______ buffers instead.

Please take a close look, as some of the ownership semantics are tricky. (esp. in the manipulation
of Tasks in master).


This addresses bug MESOS-303.
    https://issues.apache.org/jira/browse/MESOS-303


Diffs
-----

  src/master/http.cpp 636fed772a93fdc4683216e8646189a5a436daa7 
  src/master/master.hpp 1d8d0e4b0080d5efb25f8140e4a9bafdff513469 
  src/master/master.cpp 8b6c71575d57816588a52dfc0fa74e51df1bea4d 
  src/slave/http.cpp 2411e206839ec5d9a683e58e61b63b3b3ec6dc91 
  src/slave/slave.hpp be0d7cc239e51636bb07e12c3046e0751a958787 
  src/slave/slave.cpp 2bd2dbce538a6108dd9fe607829cfbdab33e0778 

Diff: https://reviews.apache.org/r/7845/diff/


Testing
-------

sudo make check

I ran a local run, with a long-lived-framework that I Ctrl+C'ed several times. This should
have caused completed tasks / executors / frameworks.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message