Return-Path: 
 <mesos-dev-return-4011-apmail-incubator-mesos-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id DACE995C9
	for <apmail-incubator-mesos-dev-archive@minotaur.apache.org>;
 Mon,  8 Oct 2012 22:11:00 +0000 (UTC)
Received: (qmail 94477 invoked by uid 500); 8 Oct 2012 22:11:00 -0000
Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org
Received: (qmail 94403 invoked by uid 500); 8 Oct 2012 22:11:00 -0000
Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mesos-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:mesos-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:mesos-dev@incubator.apache.org>
List-Id: <mesos-dev.incubator.apache.org>
Reply-To: mesos-dev@incubator.apache.org
Delivered-To: mailing list mesos-dev@incubator.apache.org
Received: (qmail 94389 invoked by uid 99); 8 Oct 2012 22:11:00 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Oct 2012 22:11:00 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id D81481C0022;
	Mon,  8 Oct 2012 22:10:58 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============0708299292292326066=="
MIME-Version: 1.0
Subject: Re: Review Request: HTTP Percent Encoding / Decoding.
From: "Benjamin Hindman" <benh@berkeley.edu>
To: "Benjamin Hindman" <benh@berkeley.edu>, "Vinod Kone" <vinodkone@gmail.com>
Cc: "Ben Mahler" <benjamin.mahler@gmail.com>,
 "mesos" <mesos-dev@incubator.apache.org>
Date: Mon, 08 Oct 2012 22:10:58 -0000
Message-ID: <20121008221058.20377.20564@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Benjamin Hindman" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-ReviewRequest-URL: https://reviews.apache.org/r/7272/
X-Sender: "Benjamin Hindman" <noreply@reviews.apache.org>
References: <20120928212146.18994.52058@reviews.apache.org>
In-Reply-To: <20120928212146.18994.52058@reviews.apache.org>
Reply-To: "Benjamin Hindman" <benh@berkeley.edu>

--===============0708299292292326066==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7272/#review12246
-----------------------------------------------------------

Ship it!



third_party/libprocess/include/process/http.hpp
<https://reviews.apache.org/r/7272/#comment25986>

    s/encodeURI/encode/



third_party/libprocess/include/process/http.hpp
<https://reviews.apache.org/r/7272/#comment25987>

    s/decodeURI/decode/



third_party/libprocess/include/process/http.hpp
<https://reviews.apache.org/r/7272/#comment25988>

    std::istringstream in(s.substr(i + 1, 2));
    long l;
    in >> std::hex >> l;
    CHECK(... 'l' fits in a char ...);
    out << static_cast<char>(l);
    =



- Benjamin Hindman


On Sept. 28, 2012, 9:21 p.m., Ben Mahler wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7272/
> -----------------------------------------------------------
> =

> (Updated Sept. 28, 2012, 9:21 p.m.)
> =

> =

> Review request for mesos, Benjamin Hindman and Vinod Kone.
> =

> =

> Description
> -------
> =

> We currently don't decode percent-encoded queries!
> =

> =

> Diffs
> -----
> =

>   src/tests/files_tests.cpp 17d284b =

>   third_party/libprocess/include/process/http.hpp d680261 =

>   third_party/libprocess/src/decoder.hpp f582faf =

>   third_party/libprocess/src/tests.cpp 1df7ae6 =

> =

> Diff: https://reviews.apache.org/r/7272/diff/
> =

> =

> Testing
> -------
> =

> Tests for encoding / decoding.
> =

> =

> Thanks,
> =

> Ben Mahler
> =

>


--===============0708299292292326066==--