-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7712/#review12704
-----------------------------------------------------------
src/linux/cgroups.hpp
<https://reviews.apache.org/r/7712/#comment27090>
Consider using Option<int> here.
src/linux/cgroups.cpp
<https://reviews.apache.org/r/7712/#comment27091>
Instead of passing the argument around, I would suggest saving it in a class field.
src/linux/cgroups.cpp
<https://reviews.apache.org/r/7712/#comment27092>
Is "&Self::checkFreeze()" allowed here? Shouldn't be "&Self::checkFreeze"?
- Jie Yu
On Oct. 24, 2012, 1:21 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7712/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2012, 1:21 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Description
> -------
>
> Part 1: This does not yet handle a failed freeze after the retry limit is reached.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp f0e343d9348075484fa5a4be739a5cef8b9dea21
> src/linux/cgroups.cpp 58e9fec193cf0da39fdbee3ee1891fd716a63bbb
> src/linux/proc.hpp dd0b30ca07c7bfb89d008f9b7a4441491fbae7fd
>
> Diff: https://reviews.apache.org/r/7712/diff/
>
>
> Testing
> -------
>
> Ubuntu 12.04: sudo make check
>
>
> Thanks,
>
> Ben Mahler
>
>
|