mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Slave Restart (Part Deux): Status Update Manager
Date Mon, 22 Oct 2012 23:44:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7212/#review12672
-----------------------------------------------------------

Ship it!


I have no more comments on the current iteration, so issuing my ship it.


src/slave/status_updates_manager.cpp
<https://reviews.apache.org/r/7212/#comment27013>

    I'm surprised boost knows how to hash StatusUpdateStreamID, must be some pretty heavy
boost magic.


- Ben Mahler


On Oct. 20, 2012, 2:43 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7212/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2012, 2:43 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> added shutdownFramework
> 
> 
> Minor fixes for open
> 
> 
> Ben's comments
> 
> 
> Refactoring SUM
> 
> 
> Bens' comments
> 
> 
> Status Update Manager
> 
> Rebased off latest trunk
> 
> Conflicts:
> 	src/Makefile.am
> 	src/common/protobuf_utils.hpp
> 	src/common/utils.hpp
> 	src/slave/slave.cpp
> 	src/tests/protobuf_io_tests.cpp
> 	src/tests/utils_tests.cpp
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am cf9364ea0418ec30a75b1774f32bda8de6e031ac 
>   src/common/protobuf_utils.hpp 77b300d7c1a02a836100d3365e205889c48ae99a 
>   src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e 
>   src/slave/status_updates_manager.hpp PRE-CREATION 
>   src/slave/status_updates_manager.cpp PRE-CREATION 
>   third_party/libprocess/include/process/timeout.hpp cac996070359a3e7ecdd8077af83c8c4cf9735fd

> 
> Diff: https://reviews.apache.org/r/7212/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message