mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Encoding HTTP Responses with gzip by default. Decoding incoming compressed messages.
Date Mon, 22 Oct 2012 17:16:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7681/#review12658
-----------------------------------------------------------

Ship it!



third_party/libprocess/src/decoder.hpp
<https://reviews.apache.org/r/7681/#comment26998>

    sounds like you can pull out a helper?


- Vinod Kone


On Oct. 20, 2012, 2:17 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7681/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2012, 2:17 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> see summary.
> 
> This helps with the performance of the webui and json endpoints.
> In production, when using the webui, we send ~900KB uncompressed data from master/state.json
(every 3 seconds, the update interval). This becomes ~90KB compressed!
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/src/decoder.hpp 5f8d70e068a9ec71555454fe4140d37993a92cc0 
>   third_party/libprocess/src/encoder.hpp 1ff84af197e2ecafe4da29310b97027805734365 
> 
> Diff: https://reviews.apache.org/r/7681/diff/
> 
> 
> Testing
> -------
> 
> This was exercised by the existing tests.
> All the tests that expect response strings (LoggingTest, FilesTest, etc).
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message