mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Refactored the cgroups tests so that they can run in a multitude of environments. See each bullet below.
Date Fri, 19 Oct 2012 01:45:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7622/#review12595
-----------------------------------------------------------



src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/7622/#comment26893>

    Did you intend to change the semantics here and elsewhere?
    ASSERT_NE(-1, _); // -1 not ok
    ASSERT_LT(0, _); // -1 ok


- Ben Mahler


On Oct. 16, 2012, 7:24 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7622/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2012, 7:24 p.m.)
> 
> 
> Review request for mesos, Vinod Kone, Jie Yu, and Ben Mahler.
> 
> 
> Description
> -------
> 
>     * Added new test fixtures:
>       (1) CgroupsNoHierarchyTest for running tests where we need to create
>           a hierarchy (and thus, most likely, no existing hierarchy can
>           exist because it will already have the cpu and or memory
>           subsystem attached).
>       (2) CgroupsAnyHierarchyTest and subclasses
>           CgroupsAnyHierarchyWithCpuMemoryTest and
>           CgroupsAnyHierarchyWithCpuMemoryFreezerTest for running tests
>           with any hierarchy provided it has necessary subsystems
>           attached.
>     
>     * Renamed cgroups (from "prof", "stu", etc. to "mesos_test") and
>       removed nested cgroups by default. The rename was done because we
>       might run tests inside of an existing hierarchy and we want to avoid
>       name clashes. The nested cgroups were removed in favor of a test
>       that explicitly tries to create nested cgroups (since some older
>       kernels with particular subsystems attached have a hard time with
>       this, and we'd like to detect that case explicitly).
>     
>     * Created an explicit test for nested cgroups (see above).
>     
>     * Updated the "write control" test to use a forked process rather than
>       the test process (to be more conservative in the presence of errors)
>     
>     * Updated the "listen event" (i.e., "oom") test to check for the
>       proper control first (memory.oom_control).
>     
>     * Updated the failure mechanism of forked (children) processes to use
>       'abort' rather than 'ASSERT_*' and 'FAIL' in order to make test
>       output more readable upon failures.
>     
>     * Updated the notify mechanism from forked (children) processes to
>       parent processes to correctly distinguish a closed pipe from a value
>       written (to catch more instances of when the test is actually
>       failing).
> 
> 
> Diffs
> -----
> 
>   src/tests/cgroups_tests.cpp a5098447081a87a2b69aadc4f1bdbd0aed7ac724 
> 
> Diff: https://reviews.apache.org/r/7622/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message