mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request: Added cgroups::hierarchies to list the currently active hierarchies and cgroups::internal::cloneCpusetValues in order to copy cpuset.cpus and cpuset.mems from a parent to a child cgroup. Also updated code to use path::join as appropriate.
Date Tue, 16 Oct 2012 20:23:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7620/#review12484
-----------------------------------------------------------



src/linux/cgroups.cpp
<https://reviews.apache.org/r/7620/#comment26578>

    To be consistent, either making this function static, or remove static modifiers from
all internal functions.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/7620/#comment26577>

    Should we add a parameter "bool cloneCpuset = true" to this function?



src/linux/cgroups.cpp
<https://reviews.apache.org/r/7620/#comment26580>

    I am wondering why using "trim" here? That will break one unit test I think.


- Jie Yu


On Oct. 16, 2012, 7:21 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7620/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2012, 7:21 p.m.)
> 
> 
> Review request for mesos, Vinod Kone, Jie Yu, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp f0e343d9348075484fa5a4be739a5cef8b9dea21 
>   src/linux/cgroups.cpp 58e9fec193cf0da39fdbee3ee1891fd716a63bbb 
>   third_party/libprocess/include/stout/path.hpp e64f8a01d004c5e6513880ed2a1a85d4ec4f9e8b

> 
> Diff: https://reviews.apache.org/r/7620/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message