mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Download endpoint for files.
Date Fri, 12 Oct 2012 22:10:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7123/
-----------------------------------------------------------

(Updated Oct. 12, 2012, 10:10 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Reverted the abstract ErrorResponse and added newlines as appropriate to the response bodies.


Description
-------

Uses the HTTP PATH type response instead.


This addresses bug MESOS-275.
    https://issues.apache.org/jira/browse/MESOS-275


Diffs (updated)
-----

  src/files/files.cpp 6d41bf6649479f83b1f5f56665b555c0c553e713 
  src/tests/files_tests.cpp 764d2c7fdec4a21b9698eb4cb9e0673bd7f20e9d 
  src/tests/utils.hpp 63f8d881da9b06f941bb104546ae03c47d140de0 
  third_party/libprocess/include/process/http.hpp 3d2922507bdb904e5bdebefbafb6ccae98c021c4

  third_party/libprocess/include/stout/os.hpp 3bc63a07e6614802497b168ab1f8372bb0c6ff24 
  third_party/libprocess/src/decoder.hpp 6db3db6ca0ca8b9a426af103e554e971f66c8ec0 
  third_party/libprocess/src/process.cpp e887feb1070cdd03a6d81b8f798145ed8bda7b5c 

Diff: https://reviews.apache.org/r/7123/diff/


Testing
-------

added download test


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message