mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Fix to the webui pailer when paging at offset 0.
Date Fri, 12 Oct 2012 21:25:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7569/#review12408
-----------------------------------------------------------

Ship it!


I'm going to commit this and cover the TODO. Thanks Ben!


src/webui/master/static/jquery.pailer.js
<https://reviews.apache.org/r/7569/#comment26225>

    s/page_size/length/ makes more sense.


- Benjamin Hindman


On Oct. 12, 2012, 7:02 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7569/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2012, 7:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> When reading the first page of the file, the page size is not adjusted accordingly. Whereas,
we should be reading an adjusted page size to get the remainder of the file.
> 
> Ex: Given a page size of 3 lines:
> [Full data]
> my
> name
> is
> ben
> 
> [Currently loaded data]
> name
> is
> ben
> 
> [Bug: Scroll up, page 3 lines again (starting at offset 0)! The page size needs to be
adjusted.]
> my
> name
> is
> name
> is
> ben
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/jquery.pailer.js edd23d9efa03086679af67a8bd13a273d409798b 
> 
> Diff: https://reviews.apache.org/r/7569/diff/
> 
> 
> Testing
> -------
> 
> make check + local run
> OSX only since purely this is purely a JS change
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message