mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: HTTP Percent Encoding / Decoding.
Date Mon, 08 Oct 2012 22:10:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7272/#review12246
-----------------------------------------------------------

Ship it!



third_party/libprocess/include/process/http.hpp
<https://reviews.apache.org/r/7272/#comment25986>

    s/encodeURI/encode/



third_party/libprocess/include/process/http.hpp
<https://reviews.apache.org/r/7272/#comment25987>

    s/decodeURI/decode/



third_party/libprocess/include/process/http.hpp
<https://reviews.apache.org/r/7272/#comment25988>

    std::istringstream in(s.substr(i + 1, 2));
    long l;
    in >> std::hex >> l;
    CHECK(... 'l' fits in a char ...);
    out << static_cast<char>(l);
    


- Benjamin Hindman


On Sept. 28, 2012, 9:21 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7272/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2012, 9:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> We currently don't decode percent-encoded queries!
> 
> 
> Diffs
> -----
> 
>   src/tests/files_tests.cpp 17d284b 
>   third_party/libprocess/include/process/http.hpp d680261 
>   third_party/libprocess/src/decoder.hpp f582faf 
>   third_party/libprocess/src/tests.cpp 1df7ae6 
> 
> Diff: https://reviews.apache.org/r/7272/diff/
> 
> 
> Testing
> -------
> 
> Tests for encoding / decoding.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message