Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============7239418358446247639=="
MIME-Version: 1.0
Subject: Re: Review Request: Updated cgroup freezer to retry after failed
 attempts
 (rather than just waiting indefinitely).
From: "Vinod Kone" <vinodkone@gmail.com>
To: "Vinod Kone" <vinodkone@gmail.com>, "Jie Yu" <yujie.jay@gmail.com>,
 "Brian Wickman" <wickman@gmail.com>
Cc: "Benjamin Hindman" <benh@berkeley.edu>,
 "mesos" <mesos-dev@incubator.apache.org>
Date: Sat, 22 Sep 2012 02:05:32 -0000
Message-ID: <20120922020532.31227.88521@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Vinod Kone" <noreply@reviews.apache.org>
References: <20120921190031.4009.98377@reviews.apache.org>
In-Reply-To: <20120921190031.4009.98377@reviews.apache.org>
Reply-To: "Vinod Kone" <vinodkone@gmail.com>

--===============7239418358446247639==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


> On Sept. 21, 2012, 7 p.m., Vinod Kone wrote:
> > lgtm. i've a feeling we need to also do a force kill. but we can do thi=
s after we see how brian's test pans out.
> =

> Benjamin Hindman wrote:
>     I tried just setting FREEZING to the cgroup freezer.state manually an=
d that didn't seem to work. Meanwhile, I sent a SIGKILL to the process in t=
he cgroup still in R, and that got everything to cleanup. So I expect that =
you're correct, and we'll also need to send explicit SIGKILLs to those proc=
esses still in R (in fact, probably just to all processes still in the cgro=
up). Review incoming.

you mean FROZEN right?


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7203/#review11794
-----------------------------------------------------------


On Sept. 21, 2012, 2:02 a.m., Benjamin Hindman wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7203/
> -----------------------------------------------------------
> =

> (Updated Sept. 21, 2012, 2:02 a.m.)
> =

> =

> Review request for mesos, Vinod Kone, Brian Wickman, and Jie Yu.
> =

> =

> Description
> -------
> =

> See summary and http://www.kernel.org/doc/Documentation/cgroups/freezer-s=
ubsystem.txt:
> =

> It's important to note that freezing can be incomplete. In that case we r=
eturn
> EBUSY. This means that some tasks in the cgroup are busy doing something =
that
> prevents us from completely freezing the cgroup at this time. After EBUSY,
> the cgroup will remain partially frozen -- reflected by freezer.state rep=
orting
> "FREEZING" when read. The state will remain "FREEZING" until one of these
> things happens:
> =

> 	1) Userspace cancels the freezing operation by writing "THAWED" to
> 		the freezer.state file
> 	2) Userspace retries the freezing operation by writing "FROZEN" to
> 		the freezer.state file (writing "FREEZING" is not legal
> 		and returns EINVAL)
> 	3) The tasks that blocked the cgroup from entering the "FROZEN"
> 		state disappear from the cgroup's set of tasks.
> =

> =

> Diffs
> -----
> =

>   src/linux/cgroups.cpp 4efd06e =

> =

> Diff: https://reviews.apache.org/r/7203/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Benjamin Hindman
> =

>


--===============7239418358446247639==--