Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 45946DD98 for ; Wed, 12 Sep 2012 21:32:25 +0000 (UTC) Received: (qmail 49218 invoked by uid 500); 12 Sep 2012 21:32:24 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 49172 invoked by uid 500); 12 Sep 2012 21:32:24 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 49155 invoked by uid 99); 12 Sep 2012 21:32:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Sep 2012 21:32:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EACF81C4179; Wed, 12 Sep 2012 21:32:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4475763787432585359==" MIME-Version: 1.0 Subject: Re: Review Request: Fix for log viewing with mesos-local.sh runs. From: "Vinod Kone" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Wed, 12 Sep 2012 21:32:22 -0000 Message-ID: <20120912213222.1602.54546@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/7061/ X-Sender: "Vinod Kone" References: <20120912212143.1601.27050@reviews.apache.org> In-Reply-To: <20120912212143.1601.27050@reviews.apache.org> Reply-To: "Vinod Kone" --===============4475763787432585359== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7061/#review11432 ----------------------------------------------------------- Ship it! src/logging/logging.hpp new line - Vinod Kone On Sept. 12, 2012, 9:21 p.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7061/ > ----------------------------------------------------------- > = > (Updated Sept. 12, 2012, 9:21 p.m.) > = > = > Review request for mesos, Benjamin Hindman and Vinod Kone. > = > = > Description > ------- > = > This eliminates the hard-coding of the log filenames: mesos-master.INFO a= nd mesos-slave.INFO. > = > = > Diffs > ----- > = > src/logging/logging.hpp 9dcc7c1 = > src/logging/logging.cpp d6d31ec = > src/master/master.cpp addabdb = > src/slave/slave.cpp 4ea1db1 = > src/webui/master/static/controllers.js 41cec18 = > = > Diff: https://reviews.apache.org/r/7061/diff/ > = > = > Testing > ------- > = > make check > mesos-local.sh runs > = > = > Thanks, > = > Ben Mahler > = > --===============4475763787432585359==--