mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Review Request: Proto -> JSON conversion using the protobuf Reflection API.
Date Mon, 17 Sep 2012 17:37:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7133/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and John Sirois.


Description
-------

This adds Proto->JSON conversion using the protobuf Reflection API.
This should help remove a lot of the json building boilerplate we have in our */http.cpp files.

Note that strings::join has already been reviewed in a pending CL: https://reviews.apache.org/r/6739/diff/?page=2


This addresses bug MESOS-269.
    https://issues.apache.org/jira/browse/MESOS-269


Diffs
-----

  src/Makefile.am b73a024 
  src/tests/stout_tests.cpp f690fac 
  src/tests/tests.proto PRE-CREATION 
  third_party/libprocess/include/stout/json.hpp 1c66dfd 
  third_party/libprocess/include/stout/protobuf.hpp d2b5dae 
  third_party/libprocess/include/stout/strings.hpp aca0b02 

Diff: https://reviews.apache.org/r/7133/diff/


Testing
-------

Added a test.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message