mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Fix for log viewing with mesos-local.sh runs.
Date Wed, 12 Sep 2012 21:32:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7061/#review11432
-----------------------------------------------------------

Ship it!



src/logging/logging.hpp
<https://reviews.apache.org/r/7061/#comment24471>

    new line


- Vinod Kone


On Sept. 12, 2012, 9:21 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7061/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2012, 9:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This eliminates the hard-coding of the log filenames: mesos-master.INFO and mesos-slave.INFO.
> 
> 
> Diffs
> -----
> 
>   src/logging/logging.hpp 9dcc7c1 
>   src/logging/logging.cpp d6d31ec 
>   src/master/master.cpp addabdb 
>   src/slave/slave.cpp 4ea1db1 
>   src/webui/master/static/controllers.js 41cec18 
> 
> Diff: https://reviews.apache.org/r/7061/diff/
> 
> 
> Testing
> -------
> 
> make check
> mesos-local.sh runs
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message