mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Replaced double with Duration in Timeout.
Date Thu, 30 Aug 2012 01:09:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6848/#review10867
-----------------------------------------------------------

Ship it!



src/java/jni/org_apache_mesos_Log.cpp
<https://reviews.apache.org/r/6848/#comment23422>

    why store into a local variable? just do Timeout(Seconds(jseconds)) as you did below.



src/java/jni/org_apache_mesos_Log.cpp
<https://reviews.apache.org/r/6848/#comment23423>

    ditto



src/java/jni/org_apache_mesos_Log.cpp
<https://reviews.apache.org/r/6848/#comment23424>

    ditto



src/java/jni/org_apache_mesos_Log.cpp
<https://reviews.apache.org/r/6848/#comment23425>

    ditto



src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/6848/#comment23426>

    s/0.0/0


- Vinod Kone


On Aug. 30, 2012, 12:56 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6848/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2012, 12:56 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/java/jni/org_apache_mesos_Log.cpp 3928b31 
>   src/log/network.hpp b25e995 
>   src/logging/logging.cpp 6909b0b 
>   src/master/hierarchical_allocator_process.hpp 86c9b1e 
>   src/tests/log_tests.cpp 85b2329 
>   third_party/libprocess/include/process/timeout.hpp 4a1f113 
>   third_party/libprocess/include/process/timer.hpp 72f7711 
>   third_party/libprocess/src/process.cpp 2b2d521 
> 
> Diff: https://reviews.apache.org/r/6848/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message