mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request: Enabling -Wall -Werror on the build
Date Fri, 10 Aug 2012 23:02:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/
-----------------------------------------------------------

(Updated Aug. 10, 2012, 11:02 p.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.


Changes
-------

changed the argv assignment to casts


Description
-------

Also, be sure to see my TODO in src/tests/utils.hpp


This addresses bug MESOS-253.
    https://issues.apache.org/jira/browse/MESOS-253


Diffs (updated)
-----

  src/Makefile.am b0cb6cc 
  src/common/attributes.cpp 77be97c 
  src/common/resources.cpp 7b410ff 
  src/common/values.cpp 957c413 
  src/configurator/configurator.cpp 135fbd2 
  src/configurator/option.hpp 6982ec3 
  src/examples/balloon_framework.cpp 045ba08 
  src/examples/long_lived_framework.cpp 369975b 
  src/examples/no_executor_framework.cpp b5f4ff9 
  src/examples/test_framework.cpp 7e0c2e2 
  src/exec/exec.cpp c9f87fa 
  src/java/jni/convert.cpp 9f52ca8 
  src/jvm/jvm.cpp 0e3614d 
  src/launcher/launcher.cpp 35cc6dd 
  src/local/local.cpp 42dbf06 
  src/log/coordinator.hpp d585b7d 
  src/log/coordinator.cpp 838852f 
  src/log/log.hpp dcbf0b1 
  src/master/constants.hpp 9214bab 
  src/master/master.hpp d21ff3c 
  src/master/master.cpp 4f62687 
  src/sched/sched.cpp a147e90 
  src/slave/slave.hpp 10c537b 
  src/slave/slave.cpp 4efd41e 
  src/state/serializer.hpp 8b28408 
  src/tests/allocator_tests.cpp b3db13d 
  src/tests/attributes_tests.cpp 1e87d923 
  src/tests/exception_tests.cpp d0d17c4 
  src/tests/fault_tolerance_tests.cpp f892282 
  src/tests/flags_tests.cpp 1372b0a 
  src/tests/gc_tests.cpp 2f0bdde 
  src/tests/log_tests.cpp 9397da4 
  src/tests/master_tests.cpp b586984 
  src/tests/multihashmap_tests.cpp c399362 
  src/tests/resource_offers_tests.cpp c004772 
  src/tests/resources_tests.cpp 897422f 
  src/tests/stout_tests.cpp 91bcc13 
  src/tests/utils.hpp a768360 
  src/tests/zookeeper_tests.cpp 7336705 
  src/webui/webui.cpp 1849ef0 
  src/zookeeper/group.cpp 8ae23f3 
  src/zookeeper/url.hpp d6d4750 
  src/zookeeper/zookeeper.cpp 621deaf 
  third_party/libprocess/include/process/protobuf.hpp 6dad48b 
  third_party/libprocess/include/stout/cache.hpp 8a7c332 
  third_party/libprocess/include/stout/os.hpp b1eceb3 
  third_party/libprocess/include/stout/strings.hpp 5bf0489 
  third_party/libprocess/include/stout/time.hpp 46d7077 

Diff: https://reviews.apache.org/r/6499/diff/


Testing
-------

make
make check


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message