mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Moved garbage collection in the slaves to a libprocess process and updated the tests.
Date Thu, 09 Aug 2012 21:08:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6476/#review10079
-----------------------------------------------------------

Ship it!


i haven't looked at the unit tests, as i would be fixing them soon.


src/slave/gc.hpp
<https://reviews.apache.org/r/6476/#comment21345>

    we should really have a time abstraction instead of seconds. but thats a different review.



src/slave/gc.cpp
<https://reviews.apache.org/r/6476/#comment21344>

    can we move this up to the header file? Or is this idiomatic for how we do things in mesos?




src/slave/gc.cpp
<https://reviews.apache.org/r/6476/#comment21356>

    promise->set(os::rmdir(path))



src/slave/slave.cpp
<https://reviews.apache.org/r/6476/#comment21361>

    s/existing/old/



src/slave/slave.cpp
<https://reviews.apache.org/r/6476/#comment21372>

    yea, this is definitely better logic than checking the modtime after we received the 
delayed message. my bad :/



src/slave/slave.cpp
<https://reviews.apache.org/r/6476/#comment21362>

    please add that we are not scheduling the directory for deletion to make debugging easier.



third_party/libprocess/include/stout/os.hpp
<https://reviews.apache.org/r/6476/#comment21370>

    aah. i like modtime. tells you what's being returned.



third_party/libprocess/include/stout/os.hpp
<https://reviews.apache.org/r/6476/#comment21369>

    Please ignore . and .. files here.
    
    if (entry->d_name == "." || entry->d_name == "..") {
      continue;
    } 


- Vinod Kone


On Aug. 8, 2012, 8:19 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6476/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 8:19 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am cc3480c 
>   src/linux/proc.cpp 0a79ca4 
>   src/slave/gc.hpp PRE-CREATION 
>   src/slave/gc.cpp PRE-CREATION 
>   src/slave/lxc_isolation_module.cpp b62d61a 
>   src/slave/slave.hpp 56b4ee2 
>   src/slave/slave.cpp d2cd62f 
>   src/tests/gc_tests.cpp PRE-CREATION 
>   src/tests/slave_tests.cpp e9b25ba 
>   src/tests/stout_tests.cpp 0cb39b9 
>   third_party/libprocess/include/stout/os.hpp e9078cc 
> 
> Diff: https://reviews.apache.org/r/6476/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message