mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Re: Review Request: Added a Java in-memory implementation of State.
Date Thu, 02 Aug 2012 20:40:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6079/#review9782
-----------------------------------------------------------

Ship it!



src/java/src/org/apache/mesos/state/InMemoryState.java
<https://reviews.apache.org/r/6079/#comment20768>

    this cast is not needed



src/java/src/org/apache/mesos/state/InMemoryState.java
<https://reviews.apache.org/r/6079/#comment20769>

    ditto



src/java/src/org/apache/mesos/state/InMemoryState.java
<https://reviews.apache.org/r/6079/#comment20772>

    this(entry, null);
    
    or even:
    this(entry, entry.value);
    
    And simplify the value() implementation below.



src/java/src/org/apache/mesos/state/InMemoryState.java
<https://reviews.apache.org/r/6079/#comment20775>

    final


- John Sirois


On Aug. 1, 2012, 4:01 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6079/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 4:01 p.m.)
> 
> 
> Review request for mesos, John Sirois and Florian Leibert.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 10f1101 
>   src/java/jni/org_apache_mesos_state_Variable.cpp PRE-CREATION 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp PRE-CREATION 
>   src/java/src/org/apache/mesos/state/InMemoryState.java PRE-CREATION 
>   src/java/src/org/apache/mesos/state/State.java PRE-CREATION 
>   src/java/src/org/apache/mesos/state/Variable.java PRE-CREATION 
>   src/java/src/org/apache/mesos/state/ZooKeeperState.java PRE-CREATION 
>   src/state/state.hpp e1d9c01 
> 
> Diff: https://reviews.apache.org/r/6079/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message