Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5A31599F8 for ; Wed, 11 Jul 2012 16:52:33 +0000 (UTC) Received: (qmail 69777 invoked by uid 500); 11 Jul 2012 16:52:33 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 69749 invoked by uid 500); 11 Jul 2012 16:52:33 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 69737 invoked by uid 99); 11 Jul 2012 16:52:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Jul 2012 16:52:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BB24D1C1774; Wed, 11 Jul 2012 16:52:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5222816968985013898==" MIME-Version: 1.0 Subject: Re: Review Request: FLAGS (4): Moved webui components from 'common' to 'webui' directory. From: "John Sirois" To: "Vinod Kone" , "John Sirois" Cc: "mesos" , "Benjamin Hindman" Date: Wed, 11 Jul 2012 16:52:32 -0000 Message-ID: <20120711165232.766.42147@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "John Sirois" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/5857/ X-Sender: "John Sirois" References: <20120709220852.766.97261@reviews.apache.org> In-Reply-To: <20120709220852.766.97261@reviews.apache.org> Reply-To: "John Sirois" --===============5222816968985013898== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5857/#review9065 ----------------------------------------------------------- Ship it! src/webui/webui.cpp Why is this hanging around? Missing TODO? - John Sirois On July 9, 2012, 10:08 p.m., Benjamin Hindman wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5857/ > ----------------------------------------------------------- > = > (Updated July 9, 2012, 10:08 p.m.) > = > = > Review request for mesos, John Sirois and Vinod Kone. > = > = > Description > ------- > = > This refactor has little to do with the configuration/flags transition, b= ut was necessary to make some things "cleaner". > = > = > Diffs > ----- > = > src/Makefile.am 11f6b4c = > src/common/webui_utils.hpp 7ac3120 = > src/common/webui_utils.cpp 6915190 = > src/master/webui.cpp 56134b7 = > src/slave/webui.cpp 5616542 = > src/webui/webui.hpp PRE-CREATION = > src/webui/webui.cpp PRE-CREATION = > = > Diff: https://reviews.apache.org/r/5857/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Benjamin Hindman > = > --===============5222816968985013898==--