Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E6F59CFFF for ; Mon, 2 Jul 2012 17:55:32 +0000 (UTC) Received: (qmail 79658 invoked by uid 500); 2 Jul 2012 17:55:32 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 79597 invoked by uid 500); 2 Jul 2012 17:55:32 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 79583 invoked by uid 99); 2 Jul 2012 17:55:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jul 2012 17:55:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 76C1A1C0246; Mon, 2 Jul 2012 17:55:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5901464682248651906==" MIME-Version: 1.0 Subject: Re: Review Request: Updated 'strings::format' to "stringify" arguments that are not POD types. From: "Vinod Kone" To: "Vinod Kone" Cc: "Benjamin Hindman" , "mesos" Date: Mon, 02 Jul 2012 17:55:27 -0000 Message-ID: <20120702175527.6556.91519@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/5691/ X-Sender: "Vinod Kone" References: <20120702055017.6557.80555@reviews.apache.org> In-Reply-To: <20120702055017.6557.80555@reviews.apache.org> Reply-To: "Vinod Kone" --===============5901464682248651906== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5691/#review8804 ----------------------------------------------------------- Ship it! Ship It! src/common/format.hpp this is swell src/common/format.hpp why this specialization? - Vinod Kone On July 2, 2012, 5:50 a.m., Benjamin Hindman wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5691/ > ----------------------------------------------------------- > = > (Updated July 2, 2012, 5:50 a.m.) > = > = > Review request for mesos and Vinod Kone. > = > = > Description > ------- > = > Pulled this out of the "paths" review and updated it to "stringify" non-P= OD types. > = > = > Diffs > ----- > = > src/Makefile.am 8760f59 = > src/common/format.hpp PRE-CREATION = > src/common/strings.hpp 37685bb = > = > Diff: https://reviews.apache.org/r/5691/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Benjamin Hindman > = > --===============5901464682248651906==--