mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Added current master "leader" to '/state.json' as well as redirection in the webui.
Date Mon, 23 Jul 2012 21:59:07 GMT


> On July 23, 2012, 4:16 p.m., John Sirois wrote:
> > src/webui/master/static/controllers.js, line 16
> > <https://reviews.apache.org/r/6083/diff/1/?file=126994#file126994line16>
> >
> >     This is kinda long - presumably you're damping here to prevent redirect thrash.
 It might be nice to add a redirect link during the countdown to allow a user to proceed right
away.

Added a "go now" link.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6083/#review9361
-----------------------------------------------------------


On July 22, 2012, 8:58 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6083/
> -----------------------------------------------------------
> 
> (Updated July 22, 2012, 8:58 p.m.)
> 
> 
> Review request for mesos, John Sirois and Vinod Kone.
> 
> 
> Description
> -------
> 
> Now, if a leader is known to one of the masters it will be included in the JSON returned
from hitting the '/state.json' endpoint. In addition, the webui will automagically redirect
to the leading master after 5 seconds.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 2568303 
>   src/master/master.hpp ad2ec25 
>   src/master/master.cpp 43407fa 
>   src/webui/master/static/controllers.js a73814e 
>   src/webui/master/static/index.html 70a5b8e 
> 
> Diff: https://reviews.apache.org/r/6083/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message