mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Re: Review Request: Fixes port type
Date Wed, 18 Jul 2012 23:23:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6039/#review9267
-----------------------------------------------------------


LG - but nits


src/master/master.cpp
<https://reviews.apache.org/r/6039/#comment19873>

    >80



src/master/master.cpp
<https://reviews.apache.org/r/6039/#comment19874>

    >80 and s/<<": "/<< ": "


- John Sirois


On July 18, 2012, 10:43 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6039/
> -----------------------------------------------------------
> 
> (Updated July 18, 2012, 10:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and John Sirois.
> 
> 
> Description
> -------
> 
> Increased storage for 'port' type from short to uint16_t
> 
> 
> This addresses bug MESOS-233.
>     https://issues.apache.org/jira/browse/MESOS-233
> 
> 
> Diffs
> -----
> 
>   src/local/main.cpp 60611c3 
>   src/master/flags.hpp c0eb61f 
>   src/master/main.cpp 8d38fb1 
>   src/master/master.cpp b5e09d8 
>   src/slave/flags.hpp 237ce02 
>   src/slave/main.cpp 5170115 
> 
> Diff: https://reviews.apache.org/r/6039/diff/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message