mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Re: Review Request: FLAGS (4): Moved webui components from 'common' to 'webui' directory.
Date Wed, 11 Jul 2012 16:52:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5857/#review9065
-----------------------------------------------------------

Ship it!



src/webui/webui.cpp
<https://reviews.apache.org/r/5857/#comment19208>

    Why is this hanging around?  Missing TODO?


- John Sirois


On July 9, 2012, 10:08 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5857/
> -----------------------------------------------------------
> 
> (Updated July 9, 2012, 10:08 p.m.)
> 
> 
> Review request for mesos, John Sirois and Vinod Kone.
> 
> 
> Description
> -------
> 
> This refactor has little to do with the configuration/flags transition, but was necessary
to make some things "cleaner".
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 11f6b4c 
>   src/common/webui_utils.hpp 7ac3120 
>   src/common/webui_utils.cpp 6915190 
>   src/master/webui.cpp 56134b7 
>   src/slave/webui.cpp 5616542 
>   src/webui/webui.hpp PRE-CREATION 
>   src/webui/webui.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/5857/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message