mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Updated 'strings::format' to "stringify" arguments that are not POD types.
Date Mon, 02 Jul 2012 17:55:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5691/#review8804
-----------------------------------------------------------

Ship it!


Ship It!


src/common/format.hpp
<https://reviews.apache.org/r/5691/#comment18625>

    this is swell



src/common/format.hpp
<https://reviews.apache.org/r/5691/#comment18626>

    why this specialization?


- Vinod Kone


On July 2, 2012, 5:50 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5691/
> -----------------------------------------------------------
> 
> (Updated July 2, 2012, 5:50 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> Pulled this out of the "paths" review and updated it to "stringify" non-POD types.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8760f59 
>   src/common/format.hpp PRE-CREATION 
>   src/common/strings.hpp 37685bb 
> 
> Diff: https://reviews.apache.org/r/5691/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message