mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Refactored path utilities into a separate file
Date Sat, 02 Jun 2012 00:16:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4944/
-----------------------------------------------------------

(Updated 2012-06-02 00:16:01.231733)


Review request for mesos, Benjamin Hindman and John Sirois.


Changes
-------

fixed test.


Summary
-------

See summary.

This diff is based on the previous utils patch (https://reviews.apache.org/r/4899). I still
need to update that patch with john's comments.

Added tests.


Diffs (updated)
-----

  src/Makefile.am 8760f59 
  src/common/protobuf_utils.hpp PRE-CREATION 
  src/common/utils.hpp ba55497 
  src/slave/path.hpp PRE-CREATION 
  src/slave/path.cpp PRE-CREATION 
  src/slave/slave.hpp 80453b0 
  src/slave/slave.cpp aac11e0 
  src/tests/path_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/4944/diff


Testing
-------

make check


Thanks,

Vinod


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message