Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Content-Type: multipart/alternative;
	boundary="===============5133567667459026140=="
MIME-Version: 1.0
Subject: Re: Review Request: Slave Garbage Collection
From: "Vinod Kone" <vinodkone@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Brian Wickman" <wickman@gmail.com>,
	"John Sirois" <john.sirois@gmail.com>
Date: Thu, 31 May 2012 17:09:01 -0000
Message-ID: <20120531170901.22577.31085@reviews.apache.org>
Cc: "mesos" <mesos-dev@incubator.apache.org>,
	"Vinod Kone" <vinodkone@gmail.com>
In-Reply-To: <20120530223354.22578.63047@reviews.apache.org>
References: <20120530223354.22578.63047@reviews.apache.org>

--===============5133567667459026140==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5072/
-----------------------------------------------------------

(Updated 2012-05-31 17:09:01.016071)


Review request for mesos, Benjamin Hindman, John Sirois, and Brian Wickman.


Changes
-------

fixed slave gc tests.


Summary
-------

This is the first cut for GC inside the slave. =


There are 2 kinds of gc going on

--> Executor work dirs -- These get deleted whenever (after a timeout) an e=
xecutor exits/shutdown
--> Old slave dirs -- These get deleted when the slave gets registered for =
the first time on a startup.


Diffs (updated)
-----

  src/Makefile.am 96cb4c6 =

  src/common/seconds.hpp 5ae088a =

  src/common/time.hpp PRE-CREATION =

  src/common/timer.hpp 71dc493 =

  src/common/utils.hpp 09d278a =

  src/log/coordinator.hpp b881c6a =

  src/log/log.hpp 79bb738 =

  src/log/network.hpp 9499c63 =

  src/master/frameworks_manager.hpp 31d708b =

  src/slave/constants.hpp f0c8679 =

  src/slave/process_based_isolation_module.cpp e76339c =

  src/slave/slave.hpp 08a29d8 =

  src/slave/slave.cpp 8585230 =

  src/state/state.hpp 6166414 =

  src/state/zookeeper.cpp e31fff7 =

  src/tests/base_zookeeper_test.hpp 2f5747e =

  src/tests/slave_tests.cpp PRE-CREATION =

  src/zookeeper/group.hpp 8646202 =

  src/zookeeper/zookeeper.hpp 5043a64 =


Diff: https://reviews.apache.org/r/5072/diff


Testing
-------

make check scucceeds.

Yet to write GC specific tests.


Thanks,

Vinod


--===============5133567667459026140==--