mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Slave Garbage Collection
Date Wed, 30 May 2012 19:45:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5072/
-----------------------------------------------------------

(Updated 2012-05-30 19:45:30.351317)


Review request for mesos, Benjamin Hindman, John Sirois, and Brian Wickman.


Changes
-------

ben's comments.


Summary
-------

This is the first cut for GC inside the slave. 

There are 2 kinds of gc going on

--> Executor work dirs -- These get deleted whenever (after a timeout) an executor exits/shutdown
--> Old slave dirs -- These get deleted when the slave gets registered for the first time
on a startup.


Diffs (updated)
-----

  src/Makefile.am 96cb4c6 
  src/common/seconds.hpp 5ae088a 
  src/common/time.hpp PRE-CREATION 
  src/common/timer.hpp 71dc493 
  src/common/utils.hpp 09d278a 
  src/log/coordinator.hpp b881c6a 
  src/log/log.hpp 79bb738 
  src/log/network.hpp 9499c63 
  src/master/frameworks_manager.hpp 31d708b 
  src/slave/constants.hpp f0c8679 
  src/slave/slave.hpp 08a29d8 
  src/slave/slave.cpp 8585230 
  src/state/state.hpp 6166414 
  src/state/zookeeper.cpp e31fff7 
  src/tests/base_zookeeper_test.hpp 2f5747e 
  src/tests/slave_tests.cpp PRE-CREATION 
  src/zookeeper/group.hpp 8646202 
  src/zookeeper/zookeeper.hpp 5043a64 

Diff: https://reviews.apache.org/r/5072/diff


Testing
-------

make check scucceeds.

Yet to write GC specific tests.


Thanks,

Vinod


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message