Return-Path: 
 <mesos-dev-return-1967-apmail-incubator-mesos-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id DB8359914
	for <apmail-incubator-mesos-dev-archive@minotaur.apache.org>;
 Fri,  6 Apr 2012 19:02:25 +0000 (UTC)
Received: (qmail 71002 invoked by uid 500); 6 Apr 2012 19:02:25 -0000
Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org
Received: (qmail 70970 invoked by uid 500); 6 Apr 2012 19:02:25 -0000
Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mesos-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:mesos-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:mesos-dev@incubator.apache.org>
List-Id: <mesos-dev.incubator.apache.org>
Reply-To: mesos-dev@incubator.apache.org
Delivered-To: mailing list mesos-dev@incubator.apache.org
Received: (qmail 70959 invoked by uid 99); 6 Apr 2012 19:02:25 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Apr 2012 19:02:25 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id CE3511C3B43;
	Fri,  6 Apr 2012 19:02:24 +0000 (UTC)
Content-Type: multipart/alternative;
	boundary="===============4292176282216394489=="
MIME-Version: 1.0
Subject: Re: Review Request: Fix for properly sending TASK LOST status updates
From: "Vinod Kone" <vinodkone@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>,
	"John Sirois" <john.sirois@gmail.com>
Date: Fri, 06 Apr 2012 19:02:24 -0000
Message-ID: <20120406190224.8078.97759@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
X-ReviewRequest-URL: https://reviews.apache.org/r/4619/
Cc: "mesos" <mesos-dev@incubator.apache.org>,
	"Vinod Kone" <vinodkone@gmail.com>
In-Reply-To: <20120405181914.2845.76829@reviews.apache.org>
References: <20120405181914.2845.76829@reviews.apache.org>

--===============4292176282216394489==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4619/
-----------------------------------------------------------

(Updated 2012-04-06 19:02:24.780345)


Review request for mesos, Benjamin Hindman and John Sirois.


Changes
-------

ben's comments


Summary
-------

This is a short-term fix, because this fix will be subsumed when with we pa=
tch with the slave restart code.


Diffs (updated)
-----

  src/master/master.cpp 4dc9ee0 =

  src/slave/slave.hpp 279bc7b =

  src/slave/slave.cpp 3358ec4 =


Diff: https://reviews.apache.org/r/4619/diff


Testing
-------

make check

(All tests except external python test succeed)

/src/examples/python/test-framework local
./src/examples/python/test-framework: line 32: test: /Users/vinod/workspace=
/apache/mesos/build/src/python/dist/mesos-0.0.1-py2.6-macosx-10.6-universal=
.egg: binary operator expected
Traceback (most recent call last):
  File "/Users/vinod/workspace/apache/mesos/build/../src/examples/python/te=
st_framework.py", line 23, in <module>
    import mesos
ImportError: No module named mesos


Thanks,

Vinod


--===============4292176282216394489==--