Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 739D4990A for ; Wed, 28 Mar 2012 02:57:52 +0000 (UTC) Received: (qmail 76181 invoked by uid 500); 28 Mar 2012 02:57:52 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 76144 invoked by uid 500); 28 Mar 2012 02:57:52 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 76115 invoked by uid 99); 28 Mar 2012 02:57:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Mar 2012 02:57:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 633701C1609; Wed, 28 Mar 2012 02:57:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1414734880203162024==" MIME-Version: 1.0 Subject: Re: Review Request: Updated deploy scripts (see description). From: "Matei Zaharia" To: "Matei Zaharia" , "Andy Konwinski" Date: Wed, 28 Mar 2012 02:57:51 -0000 Message-ID: <20120328025751.3929.94276@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/4491/ Cc: "Benjamin Hindman" , "mesos" In-Reply-To: <20120327231232.26431.31792@reviews.apache.org> References: <20120327231232.26431.31792@reviews.apache.org> --===============1414734880203162024== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4491/#review6465 ----------------------------------------------------------- Ship it! Looks good to me with the auto-detection of resources in the slave. Thanks = for spending the time on this! - Matei On 2012-03-27 23:12:32, Benjamin Hindman wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4491/ > ----------------------------------------------------------- > = > (Updated 2012-03-27 23:12:32) > = > = > Review request for mesos, Andy Konwinski and Matei Zaharia. > = > = > Summary > ------- > = > Updated deploy scripts to work with latest version of Mesos. Eliminated '= deploy-to-slaves' functionality, instead we assume the binaries and librari= es will get installed via other means. Updated the semantics of where confi= guration options are gathered from since a single configuration file was in= sufficient given conflicting configuration options between binaries (e.g., = mesos-master and mesos-slave). Added a section to the README describing the= se scripts. > = > = > Diffs > ----- > = > README 8166b04 = > configure.ac 7a0d89f = > src/Makefile.am 448410e = > src/conf/deploy-env.sh.template a4565e2 = > src/configurator/configurator.hpp ecd1365 = > src/configurator/configurator.cpp 1f8134c = > src/deploy/deploy-to-slaves 0e10486 = > src/deploy/mesos-daemon b3144c0 = > src/deploy/mesos-daemon.sh.in PRE-CREATION = > src/deploy/mesos-deploy-env.sh.template PRE-CREATION = > src/deploy/mesos-env.sh 14ad67a = > src/deploy/mesos-start-cluster.sh.in PRE-CREATION = > src/deploy/mesos-start-masters.sh.in PRE-CREATION = > src/deploy/mesos-start-slaves.sh.in PRE-CREATION = > src/deploy/mesos-stop-cluster.sh.in PRE-CREATION = > src/deploy/mesos-stop-masters.sh.in PRE-CREATION = > src/deploy/mesos-stop-slaves.sh.in PRE-CREATION = > src/deploy/start-masters a450ee0 = > src/deploy/start-mesos 9e5b922 = > src/deploy/start-slaves b3b931f = > src/deploy/stop-masters f2aa9e2 = > src/deploy/stop-mesos 679a09e = > src/deploy/stop-slaves 141acd4 = > src/master/main.cpp e88315f = > = > Diff: https://reviews.apache.org/r/4491/diff > = > = > Testing > ------- > = > N/A > = > = > Thanks, > = > Benjamin > = > --===============1414734880203162024==--