Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A5A129B01 for ; Tue, 20 Mar 2012 00:59:30 +0000 (UTC) Received: (qmail 8765 invoked by uid 500); 20 Mar 2012 00:59:30 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 8737 invoked by uid 500); 20 Mar 2012 00:59:30 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 8727 invoked by uid 99); 20 Mar 2012 00:59:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Mar 2012 00:59:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 15D2C1C387F; Tue, 20 Mar 2012 00:59:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6928078992245289428==" MIME-Version: 1.0 Subject: Re: Review Request: Clean up issues found from GCC warnings From: "Benjamin Hindman" To: "Benjamin Hindman" Date: Tue, 20 Mar 2012 00:59:30 -0000 Message-ID: <20120320005930.32682.6273@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/4396/ Cc: "Charles Reiss" , "mesos" In-Reply-To: <20120318045637.5765.42582@reviews.apache.org> References: <20120318045637.5765.42582@reviews.apache.org> --===============6928078992245289428== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4396/#review6102 ----------------------------------------------------------- Ship it! Awesome, thank you! I"ll get this committed. - Benjamin On 2012-03-18 04:56:37, Charles Reiss wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4396/ > ----------------------------------------------------------- > = > (Updated 2012-03-18 04:56:37) > = > = > Review request for mesos and Benjamin Hindman. > = > = > Summary > ------- > = > Fixes missing virtual destructors, return statements, braces found by ena= bling GCC a lot of warnings over Mesos. > = > = > Diffs > ----- > = > src/common/factory.hpp cf543c7 = > src/common/thread.hpp 8636e37 = > src/configurator/option.hpp 77d99f2 = > src/detector/detector.cpp 23dc16e = > src/master/master.cpp 0222bb2 = > src/slave/slave.hpp de304cb = > src/slave/slave.cpp ddd1874 = > src/zookeeper/zookeeper.hpp 2de5864 = > = > Diff: https://reviews.apache.org/r/4396/diff > = > = > Testing > ------- > = > = > Thanks, > = > Charles > = > --===============6928078992245289428==--