mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-143) Framework failover timeout should be specified by the framework.
Date Sat, 31 Mar 2012 21:58:30 GMT

    [ https://issues.apache.org/jira/browse/MESOS-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243307#comment-13243307
] 

jiraposter@reviews.apache.org commented on MESOS-143:
-----------------------------------------------------



bq.  On 2012-03-28 15:02:51, Rob Benson wrote:
bq.  > src/master/master.cpp, line 438
bq.  > <https://reviews.apache.org/r/4533/diff/1/?file=97213#file97213line438>
bq.  >
bq.  >     == should be <= if timeout is an int, no?

Yep. Fixed.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4533/#review6483
-----------------------------------------------------------


On 2012-03-31 21:57:43, Thomas Marshall wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4533/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-31 21:57:43)
bq.  
bq.  
bq.  Review request for mesos and Benjamin Hindman.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  When I started this project, it was somewhat complicated, but with the recent update
that passes FrameworkInfo protobufs into the MesosSchedulerDriver, all that was necessary
to allow frameworks to set their own timeouts was to add timeout as a field in FrameworkInfo
and tell master.cpp to use this value. I made it optional since some people might not care
to set it and it would just be an added complication, but I also added it to all three of
the test_frameworks (C++, Java, Python) to demonstrate its use.
bq.  
bq.  The choice for DEFAULT_FRAMEWORK_FAILOVER_TIMEOUT and MAX_FRAMEWORK_FAILOVER_TIMEOUT
was basically arbitrary, so I'm open to suggestions on what might be more appropriate.
bq.  
bq.  
bq.  This addresses bug MESOS-143.
bq.      https://issues.apache.org/jira/browse/MESOS-143
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/mesos.proto 75eee57 
bq.    include/mesos/scheduler.hpp dd09e3d 
bq.    src/examples/java/TestFramework.java 4975760 
bq.    src/examples/python/test_framework.py dd9cf98 
bq.    src/examples/test_framework.cpp c408692 
bq.    src/master/constants.hpp 8248475 
bq.    src/master/master.hpp 8a34d7e 
bq.    src/master/master.cpp 4dc9ee0 
bq.  
bq.  Diff: https://reviews.apache.org/r/4533/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Thomas
bq.  
bq.


                
> Framework failover timeout should be specified by the framework.
> ----------------------------------------------------------------
>
>                 Key: MESOS-143
>                 URL: https://issues.apache.org/jira/browse/MESOS-143
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Benjamin Hindman
>            Assignee: Thomas Marshall
>            Priority: Blocker
>
> The framework failover timeout should be specified by the framework, with perhaps an
upper limit enforced by the master. Right now two frameworks that want different failover
timeout semantics is pretty much impossible (default right now is 1 second, favoring more
"batch" like frameworks).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message