mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request: Removed the default executor.
Date Fri, 23 Mar 2012 05:17:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4448/#review6269
-----------------------------------------------------------



hadoop/hadoop-0.20.205.0.patch
<https://reviews.apache.org/r/4448/#comment13576>

    kill ws here and everywhere else



include/mesos/mesos.proto
<https://reviews.apache.org/r/4448/#comment13577>

    why are we removing the default executor? is there a jira i can look at?



src/common/type_utils.hpp
<https://reviews.apache.org/r/4448/#comment13578>

    why are you only wrapping left.resources() but not right? because Resources class can
compare directly with protobuf? probably its easier to grok if you just wrap them both?



src/master/master.cpp
<https://reviews.apache.org/r/4448/#comment13585>

    it would be cleaner to just extract task.executor() into a variable



src/master/master.cpp
<https://reviews.apache.org/r/4448/#comment13586>

    s/task's/tasks



src/master/master.cpp
<https://reviews.apache.org/r/4448/#comment13587>

    when does this happen? a different slave has an executor with the same id?



src/master/master.cpp
<https://reviews.apache.org/r/4448/#comment13589>

    This could be fixed when we merge with the new slave restart code



src/slave/slave.hpp
<https://reviews.apache.org/r/4448/#comment13590>

    can it have both?



src/tests/resource_offers_tests.cpp
<https://reviews.apache.org/r/4448/#comment13592>

    wait..what happened to task1's updates?



src/tests/resource_offers_tests.cpp
<https://reviews.apache.org/r/4448/#comment13591>

    this should be a string constant.


- Vinod


On 2012-03-23 04:42:17, Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4448/
> -----------------------------------------------------------
> 
> (Updated 2012-03-23 04:42:17)
> 
> 
> Review request for mesos, Matei Zaharia, John Sirois, and Vinod Kone.
> 
> 
> Summary
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   hadoop/hadoop-0.20.205.0.patch 909a41e 
>   include/mesos/mesos.proto 478f561 
>   include/mesos/scheduler.hpp 34018f5 
>   src/common/type_utils.hpp efa1a84 
>   src/examples/java/TestExceptionFramework.java 6859c91 
>   src/examples/java/TestFramework.java fcfac40 
>   src/examples/java/TestMultipleExecutorsFramework.java 03a104b 
>   src/examples/long_lived_framework.cpp 9ca49e5 
>   src/examples/no_executor_framework.cpp f6aa601 
>   src/examples/python/test_framework.py 388f7c0 
>   src/examples/test_framework.cpp f97d080 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 3857be3 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 590f9a2 
>   src/master/http.cpp 628112b 
>   src/master/master.cpp 6ae8aef 
>   src/python/native/mesos_executor_driver_impl.cpp 6e8fb9c 
>   src/python/native/mesos_scheduler_driver_impl.cpp 4b142ce 
>   src/python/native/module.hpp add021c 
>   src/python/native/module.cpp 59d74a4 
>   src/python/native/proxy_executor.hpp aabb6c4 
>   src/python/native/proxy_scheduler.hpp a348cbb 
>   src/sched/sched.cpp 43d9717 
>   src/slave/slave.hpp b7bc45a 
>   src/tests/exception_tests.cpp 11214c2 
>   src/tests/fault_tolerance_tests.cpp 130218d 
>   src/tests/master_tests.cpp 256945f 
>   src/tests/resource_offers_tests.cpp 303a933 
>   src/tests/utils.hpp 8c038ce 
>   src/webui/master/framework.tpl 9e384c1 
> 
> Diff: https://reviews.apache.org/r/4448/diff
> 
> 
> Testing
> -------
> 
> make check && make hadoop
> 
> 
> Thanks,
> 
> Benjamin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message