mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Clean up issues found from GCC warnings
Date Tue, 20 Mar 2012 00:59:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4396/#review6102
-----------------------------------------------------------

Ship it!


Awesome, thank you! I"ll get this committed.

- Benjamin


On 2012-03-18 04:56:37, Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4396/
> -----------------------------------------------------------
> 
> (Updated 2012-03-18 04:56:37)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Summary
> -------
> 
> Fixes missing virtual destructors, return statements, braces found by enabling GCC a
lot of warnings over Mesos.
> 
> 
> Diffs
> -----
> 
>   src/common/factory.hpp cf543c7 
>   src/common/thread.hpp 8636e37 
>   src/configurator/option.hpp 77d99f2 
>   src/detector/detector.cpp 23dc16e 
>   src/master/master.cpp 0222bb2 
>   src/slave/slave.hpp de304cb 
>   src/slave/slave.cpp ddd1874 
>   src/zookeeper/zookeeper.hpp 2de5864 
> 
> Diff: https://reviews.apache.org/r/4396/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message