mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jessica" <jessicaest...@gmail.com>
Subject Re: Review Request: Updates to get Hadoop tutorial working on Linux.
Date Wed, 14 Mar 2012 19:20:29 GMT


> On 2012-03-14 13:03:28, Jessica wrote:
> > Benjamin, IIRC, if the user does not specify to disable java when s/he runs configure,
configure checks for java/javac and exits if not found. And as far as I can tell, you can't
run make until you've run configure. Is that a correct assumption? 
> > 
> > So in the normal case, I would think it shouldn't be necessary to check for java
before running make hadoop. However, we're working with humans, and humans are generally known
to be error prone. I suppose a user could, for some strange reason, disable java when running
configure (although I can't see how that would make sense if they were planning to make Hadoop...)
or do something else bizarre like copying the files over to another machine after running
configure but before running make, so perhaps a check for javac would be in order. As much
as I hate copy-paste coding, perhaps you could copy over the check from configure... Or abstract
it into some external function? I'm not familiar enough with shell scripting to know the proper
procedure.

Related--the hadoop-env.sh patch does not modify the value of JAVA_HOME, but Hadoop requires
this value in order to run. I'm not sure if it would be best to give the user a message saying
hadoop-env.sh will need to be manually modified or if the script should try to determine the
correct value even if JAVA_HOME is not set before running.


- Jessica


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4299/#review5930
-----------------------------------------------------------


On 2012-03-12 21:50:54, Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4299/
> -----------------------------------------------------------
> 
> (Updated 2012-03-12 21:50:54)
> 
> 
> Review request for mesos, Charles Reiss and Jessica.
> 
> 
> Summary
> -------
> 
> See summary.
> 
> Note to Jessica: I made JAVA_HOME be optional, but it doesn't sound like this would be
sufficient in your environment. Do you think adding a check for 'javac' under JAVA_HOME would
help? Any other suggestions?
> 
> 
> This addresses bug MESOS-148.
>     https://issues.apache.org/jira/browse/MESOS-148
> 
> 
> Diffs
> -----
> 
>   hadoop/TUTORIAL.sh 16d87f0 
>   hadoop/hadoop-0.20.205.0_conf_hadoop-env.sh.patch 35c16a6 
> 
> Diff: https://reviews.apache.org/r/4299/diff
> 
> 
> Testing
> -------
> 
> make && make hadoop
> 
> 
> Thanks,
> 
> Benjamin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message