Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Content-Type: multipart/alternative;
	boundary="===============6124251561221554770=="
MIME-Version: 1.0
Subject: Re: Review Request: Renamed Executor Init callback
From: "Vinod Kone" <vinodkone@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Brian Wickman" <wickman@gmail.com>,
	"John Sirois" <john.sirois@gmail.com>
Date: Wed, 15 Feb 2012 01:21:42 -0000
Message-ID: <20120215012142.18863.86342@reviews.apache.org>
Cc: "mesos" <mesos-dev@incubator.apache.org>,
	"Vinod Kone" <vinodkone@gmail.com>
In-Reply-To: <20120215004410.7047.14649@reviews.apache.org>
References: <20120215004410.7047.14649@reviews.apache.org>

--===============6124251561221554770==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3761/
-----------------------------------------------------------

(Updated 2012-02-15 01:21:42.042020)


Review request for mesos, Benjamin Hindman, John Sirois, and Brian Wickman.


Changes
-------

updated diff after merge with the latest trunk.


Summary
-------

Currently, the init() callback in Executor is not consistent with the namin=
g of our callbacks. Like scheduler callback, this should be called register=
ed(). =


In the near future, we are also going to add a new executor callback called=
 re-registered() as we implement slaves being restarted without killing exe=
cutors.

As part of this, also got rid of the ExecutorArgs protobuf.


Diffs (updated)
-----

  frameworks/hadoop-0.20.2/src/contrib/mesos/src/java/org/apache/hadoop/map=
red/FrameworkExecutor.java 6744082 =

  include/mesos/executor.hpp 8e651e7 =

  include/mesos/mesos.proto b855f70 =

  src/examples/java/TestExecutor.java 6211490 =

  src/examples/long_lived_executor.cpp 6ba083b =

  src/examples/memhog_executor.cpp 333b1d9 =

  src/examples/test_executor.cpp 9dd244e =

  src/exec/exec.cpp 48c0d0f =

  src/java/jni/convert.cpp 04a25dd =

  src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp b338847 =

  src/java/src/org/apache/mesos/Executor.java a05591f =

  src/messages/messages.proto 04dc3a0 =

  src/python/native/proxy_executor.hpp 3ed9e37 =

  src/python/native/proxy_executor.cpp 30cf089 =

  src/python/src/mesos.py 026a611 =

  src/scaling/nested_exec.py 5c4edf1 =

  src/sched/sched.cpp 21d670f =

  src/slave/slave.cpp 7240139 =

  src/tests/fault_tolerance_tests.cpp 7be3d6b =

  src/tests/master_tests.cpp a411ba5 =

  src/tests/utils.hpp 660aee9 =

  third_party/libprocess/third_party/glog-0.3.1/Makefile.in 9a73fca =

  third_party/libprocess/third_party/glog-0.3.1/aclocal.m4 5515306 =

  third_party/libprocess/third_party/glog-0.3.1/configure e8760a6 =

  third_party/libprocess/third_party/glog-0.3.1/ltmain.sh e420fac =

  third_party/libprocess/third_party/glog-0.3.1/src/config.h.in b5454ba =

  third_party/libprocess/third_party/libev-3.8/Makefile.in 84f63d0 =

  third_party/libprocess/third_party/libev-3.8/aclocal.m4 e9b0602 =

  third_party/libprocess/third_party/libev-3.8/config.h.in 68cc512 =

  third_party/libprocess/third_party/libev-3.8/configure 0360536 =

  third_party/libprocess/third_party/libev-3.8/ltmain.sh c715b59 =


Diff: https://reviews.apache.org/r/3761/diff


Testing
-------

./mesos-tests --gtest_filter =3D -"*Python*"

All the tests, except the SamplePythonFramework, pass. =


Looking at earlier Jiras, looks like there is a fix for python tests, that =
needs to be pushed to the trunk? I'm not sure if that fixes this test fail =
yet.


Thanks,

Vinod


--===============6124251561221554770==--