Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7A3FB913C for ; Thu, 9 Feb 2012 01:04:00 +0000 (UTC) Received: (qmail 12585 invoked by uid 500); 9 Feb 2012 01:04:00 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 12513 invoked by uid 500); 9 Feb 2012 01:03:59 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 12502 invoked by uid 99); 9 Feb 2012 01:03:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Feb 2012 01:03:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E0D8C1C3407; Thu, 9 Feb 2012 01:03:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1529871426333511252==" MIME-Version: 1.0 Subject: Re: Review Request: Free more in Master, Slave From: "Benjamin Hindman" To: "Benjamin Hindman" Date: Thu, 09 Feb 2012 01:03:58 -0000 Message-ID: <20120209010358.16859.86711@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/3783/ Cc: "Charles Reiss" , "mesos" In-Reply-To: <20120208000317.16858.57207@reviews.apache.org> References: <20120208000317.16858.57207@reviews.apache.org> --===============1529871426333511252== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3783/#review4949 ----------------------------------------------------------- Ship it! Awesome! Thank you! - Benjamin On 2012-02-08 00:03:17, Charles Reiss wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3783/ > ----------------------------------------------------------- > = > (Updated 2012-02-08 00:03:17) > = > = > Review request for mesos and Benjamin Hindman. > = > = > Summary > ------- > = > This fixes some memory leaks of utility classes found through valgrind: > = > - the Slave never frees its Framework or Executor objects (this probably = only affects the tests); > - the Master does not free its TaskDescriptionVisitor objects properly be= cause the superclass does not have a virtual destructor (this is likely a s= low memory leak for a running Master); > = > = > Diffs > ----- > = > src/master/master.cpp fd9e6fd = > src/slave/slave.cpp 9b33a5a = > = > Diff: https://reviews.apache.org/r/3783/diff > = > = > Testing > ------- > = > = > Thanks, > = > Charles > = > --===============1529871426333511252==--