mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-120) Get 'make dist' working correctly
Date Wed, 01 Feb 2012 00:20:57 GMT

    [ https://issues.apache.org/jira/browse/MESOS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197419#comment-13197419
] 

jiraposter@reviews.apache.org commented on MESOS-120:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3588/#review4725
-----------------------------------------------------------



src/Makefile.am
<https://reviews.apache.org/r/3588/#comment10445>

    s/move/Move and kill tab (or indentation).



src/Makefile.am
<https://reviews.apache.org/r/3588/#comment10446>

    Wrap for 80 characters please.



src/Makefile.am
<https://reviews.apache.org/r/3588/#comment10447>

    I've replaced '$(top_builddir)' with '..' everywhere else in the file.



third_party/Makefile.am
<https://reviews.apache.org/r/3588/#comment10450>

    I'd love to see some documentation here explaining our strategy for third_party, and why
we decided to do it this way. Also, we need the license here too.



third_party/Makefile.am
<https://reviews.apache.org/r/3588/#comment10448>

    Not used.



third_party/Makefile.am
<https://reviews.apache.org/r/3588/#comment10449>

    Why @SUBCONFIG_ARGS@ instead of $(SUBCONFIG_ARGS)?



third_party/Makefile.am
<https://reviews.apache.org/r/3588/#comment10443>

    Wrap for 80 characters please (and everywhere else in this file).



third_party/Makefile.am
<https://reviews.apache.org/r/3588/#comment10442>

    Kill tab.


- Benjamin


On 2012-01-23 08:26:57, Charles Reiss wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3588/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-23 08:26:57)
bq.  
bq.  
bq.  Review request for mesos.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Builds third_party from tarballs instead of having us distribute the unpacked source.
bq.  
bq.  To make it sane to review, this patch does not include the tarballs or the removal of
the original third_party directories. Everything but distribute-* should be put into tarballs
for this to work.
bq.  
bq.  
bq.  This addresses bug MESOS-120.
bq.      https://issues.apache.org/jira/browse/MESOS-120
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    Makefile.am f26e555 
bq.    configure.ac bda6769 
bq.    src/Makefile.am b8fc58e 
bq.    src/python/setup.py.in 07aaa58 
bq.    src/tests/base_zookeeper_test.cpp 872bffb 
bq.    third_party/Makefile.am PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/3588/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Charles
bq.  
bq.


                
> Get 'make dist' working correctly
> ---------------------------------
>
>                 Key: MESOS-120
>                 URL: https://issues.apache.org/jira/browse/MESOS-120
>             Project: Mesos
>          Issue Type: Sub-task
>            Reporter: Benjamin Hindman
>            Assignee: Charles Reiss
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message