mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Reiss" <woggl...@gmail.com>
Subject Review Request: Free more in Master, Slave
Date Wed, 08 Feb 2012 00:03:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3783/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Summary
-------

This fixes some memory leaks of utility classes found through valgrind:

- the Slave never frees its Framework or Executor objects (this probably only affects the
tests);
- the Master does not free its TaskDescriptionVisitor objects properly because the superclass
does not have a virtual destructor (this is likely a slow memory leak for a running Master);


Diffs
-----

  src/master/master.cpp fd9e6fd 
  src/slave/slave.cpp 9b33a5a 

Diff: https://reviews.apache.org/r/3783/diff


Testing
-------


Thanks,

Charles


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message