mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Reiss" <woggl...@gmail.com>
Subject Re: Review Request: Change how we use the AC_SUBST WEBUI variable so you can build without the webui.
Date Wed, 01 Feb 2012 20:27:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3721/#review4754
-----------------------------------------------------------

Ship it!


LGTM.

- Charles


On 2012-02-01 19:34:58, Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3721/
> -----------------------------------------------------------
> 
> (Updated 2012-02-01 19:34:58)
> 
> 
> Review request for mesos and Andy Konwinski.
> 
> 
> Summary
> -------
> 
> Jenkins build breaks when we try and --disable-webui. This should fix that.
> 
> 
> Diffs
> -----
> 
>   configure.ac 283b49a 
>   src/common/webui_utils.hpp 3cd5c18 
>   src/common/webui_utils.cpp 5ad29d7 
>   src/detector/detector.cpp 6a4455a 
>   src/log/network.hpp 2e3cef4 
>   src/master/master.cpp 7fdec0e 
>   src/master/slaves_manager.cpp 0bb7397 
>   src/master/webui.hpp 97066af 
>   src/master/webui.cpp d94f728 
>   src/slave/webui.hpp 3d98d92 
>   src/slave/webui.cpp dc3cfc6 
>   src/tests/sample_frameworks_tests.cpp 5b367c9 
> 
> Diff: https://reviews.apache.org/r/3721/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message