mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Re: Review Request: Changed jobject to jweak where necessary.
Date Wed, 01 Feb 2012 17:33:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3720/#review4748
-----------------------------------------------------------

Ship it!


- John


On 2012-02-01 17:31:12, Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3720/
> -----------------------------------------------------------
> 
> (Updated 2012-02-01 17:31:12)
> 
> 
> Review request for mesos and John Sirois.
> 
> 
> Summary
> -------
> 
> To deal with compilation erros on Mac OS X 10.7:
> 
> java/jni/org_apache_mesos_MesosSchedulerDriver.cpp: In function 'void Java_org_apache_mesos_MesosSchedulerDriver_finalize(JNIEnv*,
__jobject*)':
> java/jni/org_apache_mesos_MesosSchedulerDriver.cpp:493: error: invalid conversion from
'__jobject*' to '__jweak*'
> java/jni/org_apache_mesos_MesosSchedulerDriver.cpp:493: error:   initializing argument
1 of 'void _Jv_JNIEnv::DeleteWeakGlobalRef(__jweak*)'
> 
> 
> This addresses bug MESOS-32.
>     https://issues.apache.org/jira/browse/MESOS-32
> 
> 
> Diffs
> -----
> 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 3ea1131 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 8704663 
> 
> Diff: https://reviews.apache.org/r/3720/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message